fix(codex): share trigger-only delegation guidance with v1 - #4034
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughV1 proactive delegation guidance now uses the shared v2 recommendation text at ChangesV1 proactive delegation guidance
Priority: ⬇️ Low — Defer this change because it clarifies advisory v1 delegation guidance and localized documentation without changing runtime triggers, permissions, or product behavior. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to V1 now uses the shared proactive delegation guidance at max and ultra effort while retaining existing authority, scope, and collaboration rules. The documented behavior and compatibility coverage support merging without an outstanding material risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (9 skipped: 9 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Please review head The runtime change aliases the existing v1 Independent-literal regressions fail on the baseline and pass after the change. The full compatibility file passed 63 tests / 241 assertions, including old v1 wording followed by one new guidance item and deduplication on the next replay. Typecheck, privacy scan, diff check, and the 425-page documentation build passed; all eight changed language paragraphs were checked in generated HTML. An independent read-only review found no required corrections. The pull request remains draft pending full contributor CI and current-head review. |
|
✅ Deterministic PR hygiene checks passed. |
|
Oops, something went wrong! Please try again later. 🐰 💔 |
|
@coderabbitai review The previous review request returned a service error; no formal review or inline findings were produced. Please retry that review for the unchanged head The focused compatibility file passed 63 tests / 241 assertions; typecheck, privacy scan, diff check, and the 425-page documentation build passed. Full contributor CI is running at https://github.com/luvs01/opencodex/actions/runs/34232583711. The existing recommendation module and released legacy literals remain unchanged; only v1's export now uses the shared recommendation, with regression and localized documentation updates. |
|
✅ Action performedReview finished.
|
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. Hygiene✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 41 / 80이 PR은 v1 다중 에이전트 안내 문장을, 이미 정책 모듈에 있는 공유 추천 문구와 같게 맞추려는 초안(draft) 변경입니다. 지금 왜 지금 범위는 작습니다. 런타임 파일은 collaboration.ts 한 곳의 export 연결 + 주석, 테스트, 문서입니다. 레거시 preset 바이트는 정책 모듈에 그대로 두어 이미 대화에 남은 옛 developer 메시지를 지우거나 강제 덮어쓰지 않습니다. inject 쪽 회귀도 히스토리의 legacy 한 번 + 새 문구 한 번을 유지한 채 재주입하지 않는지 확인합니다. types.ts/config.ts 분할 캠페인과도 무관해서 close-don't-rebase 대상이 아닙니다. 우선순위가 중간 아래인 이유는, 제품 tip(#4002 등)이나 런타임/할당량 버그보다 문서·조언 정렬이고, draft라 머지 트레인에 바로 넣기 이르기 때문입니다. 그래도 v1/v2 안내가 같은 문장을 쓰게 되면 사용자·메인테이너가 “트리거만 바뀌고 권한/범위 규칙은 남는다”를 오해할 여지가 줄어듭니다. 라인 collaboration.ts PROACTIVE_MULTI_AGENT_MODE_TEXT - HEAD의 로컬 문장 배열을 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
* test(lib): make idle deadline reset timing deterministic Carried from #4041 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * test: stabilize Windows fixture waits and case cleanup Carried from #4015 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * test(codex): verify timeout termination without racing child timers Carried from #4012 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * test(codex): hold prompt-probe admission through document edits Carried from #4014 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * test(clients): bound transaction fixture child completion Carried from #4004 (author luvs01) for maintainer-side CI and sequential integration. Closes #4003 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(codex): retain overlapping multiline TOML terminators Carried from #4039 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(cli): reject unsupported caps and report ignored legacy values Carried from #4043 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(codex): share trigger-only delegation guidance with v1 Carried from #4034 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(codex): preserve settings when journal injection hashes are missing Carried from #4006 (author luvs01) for maintainer-side CI and sequential integration. Closes #4005 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * docs(cli): note that --injection still accepts none and minimal CodeRabbit review on #4049: the effort reference documents caps only, so the new rejection of none/minimal reads as a global removal. --injection keeps both values because it sets the injection effort rather than a cap. --------- Co-authored-by: t <a@b.com> Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
|
Landed on Verification at the exact merged head Closing this PR because the change is already on |
lidge-jun
added
the
landed-via-maintainer
2 participants
Summary
The v1 top-effort path maintains a separate legacy delegation message, so it misses the clearer boundaries already present in the shared proactive recommendation. Use
MULTI_AGENT_MODE_HINT_RECOMMENDATION.textthrough the existingPROACTIVE_MULTI_AGENT_MODE_TEXTexport.V1 guidance at
maxorultranow says that only the separate delegation-request trigger changes; user instructions, authority, task scope, and collaboration-tool rules still apply. The existing surface detection, opt-out and effort conditions continue to select this guidance. V2 metadata and native preset settings retain their current behavior. This updates advisory wording, without claiming to enforce agent behavior or revoke instructions already in conversation history.The regression covers the exact recommendation and an old-wording → new-wording → repeated-new-wording continuation. The policy invariant and the existing v1 paragraph in all eight language guides describe the same contract. Released legacy preset bytes in the policy module remain unchanged.
Verification
eb835fe335c3449d08cb3183606d1cefc2230bc4, based ondev29bb221c3cfad89e4920ac411c9681073929c152; Bun 1.4.0 on Windows.bun run test -- --timeout 60000 --parallel=1 tests/codex-integration/multi-agent-compat.test.ts: 63 tests / 241 assertions passed, 9.24 seconds. This includes v1 opt-out/lower-effort and non-agent exclusions, v2 guidance, placement, and replay deduplication. Expected current and historical text are independent literals.bun run typecheck,bun run privacy:scan, andgit diff --checkpassed. The existing recommendation and byte-exact legacy preset module have no diff.eb835fe33. CodeRabbit's current-head review covers all 11 files and reports no actionable comments or outstanding material risk. Its first request returned a service error; one retry completed successfully. The docstring-coverage warning is advisory; no production function was added. Independent read-only review also found no required corrections.Checklist
Review readiness checklist